Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Indiquer si l'utilisateur se connecte via SSO sur Pix admin (PIX-14788) #11310

Merged
merged 2 commits into from
Feb 7, 2025
Merged

[FEATURE] Indiquer si l'utilisateur se connecte via SSO sur Pix admin (PIX-14788) #11310

merged 2 commits into from
Feb 7, 2025

Conversation

theotime2005
Copy link
Contributor

@theotime2005 theotime2005 commented Feb 3, 2025 •
edited
Loading

🥞 Problème

Lorsqu'on se rend sur la page d'un utilisateur sur Pix admin il faut se rendre dans ses méthodes de connexion pour savoir s’il utilise un SSO.

🥓 Proposition

Sous la case Identifiant, ajouter un champ SSO avec oui ou non.

🧃 Remarques

Le GAR fait parti des SSO.

😋 Pour tester

  • Se rendre sur Pix Admin
  • Se connecter avec le compte [email protected]
  • Aller sur la section des utilisateurs
  • Rechercher l'utilisateur [email protected]
  • Afficher la page de l'utilisateur
  • Constater sous le champ identifiant qu'un nouveau champ est présent avec écrit: "SSO : Non"
  • Revenir sur la page des utilisateurs
  • Rechercher l'utilisateur [email protected] présent dans les seeds
  • Afficher la page de cet utilisateur
  • Constater sous le champ identifiant qu'un nouveau champ est présent avec écrit: "SSO : Oui",
  • Revenir sur la liste des utilisateurs,
  • Rechercher par email l'utilisateur "[email protected]",
  • Constater sous le champ identifiant qu'un nouveau champ est présent avec écrit: "SSO : Oui".

@theotime2005 theotime2005 self-assigned this Feb 3, 2025
@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@theotime2005 theotime2005 force-pushed the pix-14788-show-sso-info-in-pix-admin branch 3 times, most recently from f8f6c5d to c18f004 Compare February 4, 2025 15:45
@theotime2005 theotime2005 marked this pull request as ready for review February 4, 2025 21:56
@theotime2005 theotime2005 force-pushed the pix-14788-show-sso-info-in-pix-admin branch from c18f004 to 6e90c03 Compare February 5, 2025 10:02
@P-Jeremy
Copy link
Contributor

P-Jeremy commented Feb 5, 2025

Test func Alex Terieur OK ✅
"SSO: non"

Test func Paul Emplois KO ❌
"SSO: non"

@theotime2005 theotime2005 force-pushed the pix-14788-show-sso-info-in-pix-admin branch from 13018a2 to 7e6223b Compare February 5, 2025 15:43
@theotime2005 theotime2005 force-pushed the pix-14788-show-sso-info-in-pix-admin branch from e70f089 to 728c9cd Compare February 7, 2025 09:29
@theotime2005 theotime2005 force-pushed the pix-14788-show-sso-info-in-pix-admin branch 2 times, most recently from cf064aa to 2dacf16 Compare February 7, 2025 12:53
@theotime2005 theotime2005 requested a review from a team as a code owner February 7, 2025 12:53
@theotime2005 theotime2005 added 👀 Tech Review Needed 👀 Func Review Needed Need PO validation for this functionally and removed Development in progress labels Feb 7, 2025
@theotime2005 theotime2005 force-pushed the pix-14788-show-sso-info-in-pix-admin branch from 2dacf16 to afd425a Compare February 7, 2025 12:56
lego-technix
lego-technix reviewed Feb 7, 2025
View reviewed changes
Copy link
Contributor

@lego-technix lego-technix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toute petite remarque sur la séparation entre les traitements et la présentation.

admin/app/components/users/user-overview.gjs Outdated Show resolved Hide resolved
admin/app/components/users/user-overview.gjs Outdated Show resolved Hide resolved
lego-technix
lego-technix approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@lego-technix lego-technix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Lu et testé fonctionnellement avec succès avec Firefox 🦊

@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@theotime2005 theotime2005 force-pushed the pix-14788-show-sso-info-in-pix-admin branch from 26c1186 to 1ffdd99 Compare February 7, 2025 16:29
@theotime2005 theotime2005 force-pushed the pix-14788-show-sso-info-in-pix-admin branch 3 times, most recently from 471d4c5 to 8e69a72 Compare February 7, 2025 17:03
lego-technix
lego-technix approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@lego-technix lego-technix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Lu et testé fonctionnellement la totale (SSO OIDC et SSO GAR) avec succès avec Firefox 🦊

@theotime2005 theotime2005 force-pushed the pix-14788-show-sso-info-in-pix-admin branch from 8e69a72 to 11f71ac Compare February 7, 2025 17:10
@theotime2005 theotime2005 added Tech Review OK 🚀 Ready to Merge Func Review OK PO validated functionally the PR Design Review OK and removed 👀 Tech Review Needed 👀 Func Review Needed Need PO validation for this functionally labels Feb 7, 2025
@pix-service-auto-merge pix-service-auto-merge merged commit e2eef6b into dev Feb 7, 2025
9 of 11 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the pix-14788-show-sso-info-in-pix-admin branch February 7, 2025 17:18
@lego-technix lego-technix mentioned this pull request Feb 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-Jeremy P-Jeremy P-Jeremy approved these changes

@lego-technix lego-technix lego-technix approved these changes

Assignees

@theotime2005 theotime2005

Labels
Design Review OK Func Review OK PO validated functionally the PR 🚀 Ready to Merge team-acces Tech Review OK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@theotime2005 @pix-bot-github @P-Jeremy @lego-technix @pix-service-auto-merge